From fbdabf93e887f7fdee9cffbe815d9214a14b3747 Mon Sep 17 00:00:00 2001 From: Ian Munsie Date: Thu, 9 Nov 2017 22:01:05 +1100 Subject: [PATCH] Ambiences: Do not clobber user set system tones in default ambiences The default ambiences all set the system tones back to the defaults, which is not only redundant since that is what they default to, but also removes user customisations. This effectively renders the default ambiences unusable for users who have customised their ring tone or other tones unless they also customise every default ambience that they intend to use - this is asking users to work around our bug, which is not ideal. Since setting these tones back to default serves literally zero use cases, simply remove them to resolve this issue. This will not have any impact on users who wish to use the default tones by default, since they are still the default. It will however offer a dramatic life improvement to our users who wish to customise their ringtones. Later, we can improve ambiences further to restore the previously set tones when they are unset (assuming they have not since been changed by the user), which would then allow ambiences that also set a sound scheme to work as intended. At that time, we should also remove "ringerVolume" from each of these ambiences (except silent) as that is inappropriate for ambiences to set that are not setting a sound scheme, but for now this is a necessary hack so that the silent profile will work as expected, so that is left in. Signed-off-by: Ian Munsie --- usr/share/ambience/flow/flow.ambience | 9 +-------- usr/share/ambience/origami/origami.ambience | 9 +-------- usr/share/ambience/party/party.ambience | 9 +-------- usr/share/ambience/sailing/sailing.ambience | 9 +-------- usr/share/ambience/work/work.ambience | 9 +-------- 5 files changed, 5 insertions(+), 40 deletions(-) diff --git a/usr/share/ambience/flow/flow.ambience b/usr/share/ambience/flow/flow.ambience index 00f0406..255a416 100644 --- a/usr/share/ambience/flow/flow.ambience +++ b/usr/share/ambience/flow/flow.ambience @@ -9,12 +9,5 @@ "ringerVolume" : 80, "favorite" : true, "timestamp" : "2015-01-01T00:00:01", - "version" : 2, - "ringerToneFile" : { "enabled": 1 }, - "messageToneFile" : { "enabled": 1 }, - "mailToneFile" : { "enabled": 1 }, - "internetCallToneFile" : { "enabled": 1 }, - "chatToneFile" : { "enabled": 1 }, - "calendarToneFile" : { "enabled": 1 }, - "clockAlarmToneFile" : { "enabled": 1 } + "version" : 2 } diff --git a/usr/share/ambience/origami/origami.ambience b/usr/share/ambience/origami/origami.ambience index edb262d..0207cf4 100644 --- a/usr/share/ambience/origami/origami.ambience +++ b/usr/share/ambience/origami/origami.ambience @@ -9,12 +9,5 @@ "ringerVolume" : 80, "favorite" : true, "timestamp" : "2015-01-01T00:00:04", - "version" : 2, - "ringerToneFile" : { "enabled": 1 }, - "messageToneFile" : { "enabled": 1 }, - "mailToneFile" : { "enabled": 1 }, - "internetCallToneFile" : { "enabled": 1 }, - "chatToneFile" : { "enabled": 1 }, - "calendarToneFile" : { "enabled": 1 }, - "clockAlarmToneFile" : { "enabled": 1 } + "version" : 2 } diff --git a/usr/share/ambience/party/party.ambience b/usr/share/ambience/party/party.ambience index 622afb3..d50086e 100644 --- a/usr/share/ambience/party/party.ambience +++ b/usr/share/ambience/party/party.ambience @@ -9,12 +9,5 @@ "ringerVolume" : 80, "favorite" : true, "timestamp" : "2015-01-01T00:00:03", - "version" : 2, - "ringerToneFile" : { "enabled": 1 }, - "messageToneFile" : { "enabled": 1 }, - "mailToneFile" : { "enabled": 1 }, - "internetCallToneFile" : { "enabled": 1 }, - "chatToneFile" : { "enabled": 1 }, - "calendarToneFile" : { "enabled": 1 }, - "clockAlarmToneFile" : { "enabled": 1 } + "version" : 2 } diff --git a/usr/share/ambience/sailing/sailing.ambience b/usr/share/ambience/sailing/sailing.ambience index 716e2f0..5f3f7df 100644 --- a/usr/share/ambience/sailing/sailing.ambience +++ b/usr/share/ambience/sailing/sailing.ambience @@ -9,13 +9,6 @@ "ringerVolume" : 80, "favorite" : true, "timestamp" : "2015-01-01T00:00:06", - "version" : 2, - "ringerToneFile" : { "enabled": 1 }, - "messageToneFile" : { "enabled": 1 }, - "mailToneFile" : { "enabled": 1 }, - "internetCallToneFile" : { "enabled": 1 }, - "chatToneFile" : { "enabled": 1 }, - "calendarToneFile" : { "enabled": 1 }, - "clockAlarmToneFile" : { "enabled": 1 } + "version" : 2 } diff --git a/usr/share/ambience/work/work.ambience b/usr/share/ambience/work/work.ambience index d928983..f8798c0 100644 --- a/usr/share/ambience/work/work.ambience +++ b/usr/share/ambience/work/work.ambience @@ -9,12 +9,5 @@ "ringerVolume" : 80, "favorite" : true, "timestamp" : "2015-01-01T00:00:02", - "version" : 2, - "ringerToneFile" : { "enabled": 1 }, - "messageToneFile" : { "enabled": 1 }, - "mailToneFile" : { "enabled": 1 }, - "internetCallToneFile" : { "enabled": 1 }, - "chatToneFile" : { "enabled": 1 }, - "calendarToneFile" : { "enabled": 1 }, - "clockAlarmToneFile" : { "enabled": 1 } + "version" : 2 } -- 2.11.0